Why and how to Bulkify your Code

Hello David,
I have one doubt…
if i insert 1000 records using data loader and it makes one trigger to run, how the trigger.new will handle all the 1000 records because trigger.new can only handle 200 records?
Please explain

trigger try12 on BMCServiceDesk__Incident__c (after update)
{
for(BMCServiceDesk__Incident__c inc1:trigger.old)
for(BMCServiceDesk__Incident__c inc2:trigger.new)

for(BMCServiceDesk__Incident__c inc:trigger.new)
{
//retriving current incident id
BMCServiceDesk__Incident__c id1 =[select id from BMCServiceDesk__Incident__c where id in:trigger.new];

//task object and task id related to current incident whose status is not closed
LIST task = new LIST();
task=[select id,name,BMCServiceDesk__FKIncident__c,BMCServiceDesk__FKStatus__c from BMCServiceDesk__Task__c where BMCServiceDesk__FKIncident__c=:id1.id and BMCServiceDesk__FKStatus__c!=:’a3w2800000002wKAAQ’ ];

//problem object and problem id related to current incident whose status is not closed

//geting previous status and new current status

//checking for previous status is not equal to close/reswolved and current status is equal to resolved

if(inc1.BMCServiceDesk__FKStatus__c !=’a3w2800000002wKAAQ’|| inc1.BMCServiceDesk__FKStatus__c !=’a3w2800000002x9AAA’ && inc2.BMCServiceDesk__FKStatus__c ==’a3w2800000002x9AAA’ )
{

//updating staus of task to closed status whose incident status is resolved
for(BMCServiceDesk__Task__c taskupdate : task)
{
taskupdate.BMCServiceDesk__FKStatus__c = ‘a3w2800000002wKAAQ’;
update taskupdate;
}system.debug(‘hellllo u r in if’);

//probelm id
LISTproblem=[Select id,BMCServiceDesk__FKStatus__c from BMCServiceDesk__Problem__c where BMCServiceDesk__FKStatus__c!=:’a3w2800000002wKAAQ’ and (id in(select BMCServiceDesk__FKProblem__c from BMCServiceDesk__Incident_Problem_Link__c where BMCServiceDesk__FKIncident__c=:id1.id))];
LISTproblem1=new LIST();

for(BMCServiceDesk__Problem__c probupdate : problem)
{
probupdate.BMCServiceDesk__FKStatus__c = ‘a3w2800000002wKAAQ’;
problem1.add(probupdate);
//update probupdate;
}update problem1;

//change id
// List change = [Select id,BMCServiceDesk__FKStatus__c from BMCServiceDesk__Change_Request__c where BMCServiceDesk__FKStatus__c!=:’a3w2800000002wKAAQ’ and (id in(select BMCServiceDesk__FKChange__c from BMCServiceDesk__Incident_Change_Link__c where BMCServiceDesk__FKIncident__c=:id1.id))];
List change1 = new List();

for(BMCServiceDesk__Change_Request__c changeupdate1 : [Select id,BMCServiceDesk__FKStatus__c from BMCServiceDesk__Change_Request__c where BMCServiceDesk__FKStatus__c!=:’a3w2800000002wKAAQ’ and (id in(select BMCServiceDesk__FKChange__c from BMCServiceDesk__Incident_Change_Link__c where BMCServiceDesk__FKIncident__c=:id1.id))])
{
changeupdate1.BMCServiceDesk__FKStatus__c = ‘a3w2800000002wKAAQ’;
change1.add(changeupdate1);
//update changeupdate1;
}update change1;
}

}

}

THIS CODE IS GIVING SOQL 101 ERROR CAN ANY ONE HELP ME TO SOLVE THIS PROBLEM

Hi David,

Thanks for your amazing tutorials. I have actually been stuck in bulking up my code and will highly appreciate if you can help me fix this issue.

For less than 100 contacts in any Org (or somewhere in between 1 to 80) the trigger works absolutely fine. However, it is generating the SOQL limit exceed error if the contacts in any account are more than 100.

The trigger just change the field “relationship_category__r__c” to “Member – staff” or “Member – past” when the account type is changed to “member” or “member – past” respectively.

I have tried to bulk the code and update the contacts after the loop but still it’s generating error

Thanks very much for your help,

Muhammad

trigger Update_related_Contacts_On_Account_fieldchange on Account (after update) {
set ids=new set();

for(Account acc:trigger.new){
ids.add(acc.id);
}
map<id,List> acc_con_maps=new map<id,List>();
List accts=new List([select id,(select id,Relationship_Category_r__c from contacts) from Account where id=:ids]);
For(Account accts1:accts){
acc_con_maps.put(accts1.id,accts1.contacts);
}

list constoupdate=new list();
for(Account acc1:trigger.new){
if(acc_con_maps.containsKey(acc1.Id)&&acc_con_maps.get(acc1.id)!=null){
if(acc1.Type==’Member’){

for(contact con:acc_con_maps.get(acc1.Id)){
if(con.Relationship_Category_r__c !=’Member’){
con.Relationship_Category_r__c =’Member – Staff’;
constoupdate.add(con);
}
}
}
else if(acc1.type==’Member – Past’){

for(contact con1:acc_con_maps.get(acc1.Id)){
if(con1.Relationship_Category_r__c !=’Member – Past’){
con1.Relationship_Category_r__c =’Member – Past’;
constoupdate.add(con1);
}
}
}

}
}
update constoupdate;

}

Hi David,
Received my Head First Java book today and have been reading your site everyday! Thank You for giving hope that the coding giant can be splayed :)

Question: Is it absolutely necessary to bulkify for every trigger I write? I am trying my hand on a trigger that will change the record type of the Event object when a certain profile creates/updates it on an Opportunity. I am planning to use a bunch of IF statements like you said in one of your posts. Any thoughts?

Thank you in advance!

I have a trigger where I want to prevent a user from adding duplicate records in a custom object that is related to the standard Account object.

In that scenario I want to check whether any records exist by comparing the CreatedByID with the userinfo.getUserID().

I have a working trigger that does a SOQL query inside the for loop. However, based on what I’ve read on this website, this is a bad idea due to governor limits.

Is it possible to bulkify this?

trigger preventDuplicates on Target_Account__c (before insert) {

For (Target_Account__c tt : Trigger.new) {
Integer counter = [Select Count() FROM Target_Account__c WHERE Account__c = :tt.Account__c AND CreatedById = :userinfo.getUserId()];

if(counter > 0) {
String errorMessage = ‘Duplicate Top Target Found!’;
tt.addError(errorMessage);
}
}
}