Fix this trigger: Lazy Employee

// This lazy dude wrote code to auto-accept and close all cases!
trigger LazyEmployee on Case (after insert) {
List newCases = new List();
newCases = [Select id, Owner, Status from Case where Owner = ‘David Liu’]
for (Case a : Trigger.new) {
a.Status = “Closed”;
a.Owner = “David Liu”;
newCases.add(a)
}
update newCases;
}

trigger LazyEmployee on Case (before insert) { //1. After triggers are read only, so it needs to be a before trigger
List newCases = new List();

newCases = [SELECT Id FROM Case WHERE Id IN Trigger.New AND
Status!=’Closed’ ];
for (Case a : newCases) { // 2.The for loop can be more efficient by looping over only new and open cases
a.Status = “Closed”;
a.Owner = “David Liu”;
newCases.add(a); // 3.This line missed the ending semi-colon.
}
update newCases;
}

trigger name on Leads(before insert ,before update) {

for(Leads a:Trigger.new)
{
a.status = ‘closed’;
a.Ownerid = ‘0057F0000018aoe’;

}

}

trigger LazyEmployee on Case (before insert) {
List newCases = new List();
for (Case a : Trigger.new) {
a.Status = ‘Closed’;
a.OwnerId = Userinfo.getUserId();
newCases.add(a);
}

}

// This lazy dude wrote code to auto-accept and close all cases!
trigger LazyEmployee on Case (after insert) {
List newCases = new List();
User usr=[Select ID from user where name=’David Liu’ LIMIT 1];
for (Case a : Trigger.new) {
a.Status = ‘Closed’;
a.OwnerID = usr.id;
newCases.add(a);
}
update newCases;
}

trigger LazyEmployee on Case (before insert) {
for (Case a : Trigger.new) {
a.Status = “Closed”;
a.Owner = “18 digitsId”;

}

}

// This lazy dude wrote code to auto-accept and close all cases!
trigger LazyEmployee on Case (before insert) {
for (Case a : Trigger.new)
{
a.Status = ‘Closed’;
a.Ownerid = ‘0057F0000019aoe’;
}
}

trigger LazyEmployee on Case(before insert){//as after insert will give final exception
List newCases = new List(); //not required
Id ownerId;
OwnerId = System.Label.OwnerId;//as there can be more People named David we need to save that value somewhere custom setting or Custom label
for (Case a : Trigger.new) {
a.Status = “Closed”;
a.OwnerId = OwnerId;//need to provide id instead of a String and there is no field on case as owner its always OwnerId
newCases.add(a)//semi colon missing but we do not need this statement as we are doing in trigger rather than any other class
}
update newCases;// Not required.
}

trigger LazyEmployee on Case (before insert) {
for (Case a : Trigger.new) {
a.Status = “Closed”;
a.Owner = “David Liu”;
}
}

trigger LazyEmployee on Case (before insert) {
// this should be a before trigger as we are updating the values of a new case, in after trigger we get an exception as ‘the record is read-only’
List newCases = new List();
for (Case a : Trigger.new) {
a.Status = ‘Closed’; //this should be in single quotes instead of double
a.OwnerID = userinfo.getUserId(); //here we should fetch the current user id and Assign to OwnerID
newCases.add(a); //semi-Colon;
}
//update newCases; –>This is not required as we are updating values before committing to the object
}

=======================================================

Please correct me if I am wrong.

trigger LazyEmployee on Case (after insert) {
List newCases = new List();
ID userID = [Select id from user Where Name = ‘David Liu’].ID;
for (Case a : Trigger.new) {
a.Status = ‘Closed’;
a.Owner = ID;
newCases.add(a)
}
update newCases;
}

trigger LazyEmployee on Case (before insert) {
for (Case a : Trigger.new) {
a.Status = ‘Closed’;
a.OwnerId = “David Liu”;
newCases.add(a)
}
}

Hi David ,
This is what I ended with …. Pls let me know if I m correct…

trigger LazyEmployee on Case (after insert) {

List newCases = new List();
User u = [select id from User where Name = ‘David Liu’];
for (Case a : Trigger.new) {
a.Status = ‘Closed’; // Single Quotes
a.OwnerID = u.id; // Comparing with same type
newCases.add(a); // Semicolon Missing
}
update newCases;
}

// This lazy dude wrote code to auto-accept and close all cases!
trigger LazyEmployee on Case (after insert) {
if (Trigger.isAfter && Trigger.isInsert) {
User davidLiu = new User();
davidLiu = [SELECT Id, isActive FROM User WHERE Name = ‘David Liu’ LIMIT 1];
if (davidLiu != null && davidLiu.isActive) {
List newCases = new List();
for (Case a : Trigger.new) {
if (UserInfo.getUserId() == davidLiu.Id) {
newCases.add(new Case(Id = a.Id, Status=’Closed’, OwnerId = davidLiu.Id));
}
}
if (newCases.size()>0){
update newCases;
}
}
}
}

Guys…… I would go for a workflow for such a simple requirement and never write a trigger

trigger LazyEmployee on Case (before insert) {

//List newCases = new List();
if(Trigger.isinsert){
for(Case c : Trigger.new){
if(c.status != ‘closed’ && c.status != ”){
c.status = ‘closed’;
//c.Ownerid = u.id;
//newCases.add(c);
}
}
//update newCases;
}

// This lazy dude wrote code to auto-accept and close all cases!
//Change 1: Change ‘after’ insert to ‘before’ insert to avoid a DML at the end
trigger LazyEmployee on Case (before insert) {
//List newCases = new List();

//Change 2: Query for the ID
Id userId = [SELECT Id from User where Name = ‘David Liu’ LIMIT 1].Id;
for (Case a : Trigger.new) {
a.Status = “Closed”;
//Change 3: OwnerId to be specified instead of Owner
//a.Owner = “David Liu”;
a.OwnerId = userId;

//newCases.add(a)
}
//update newCases;
}